Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy] Settled order count metric #3115

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Conversation

fleupold
Copy link
Contributor

@fleupold fleupold commented Nov 7, 2024

Description

In order to improve our settlement throughput alerting I'd like to plot the number of orders we settle per minute over time (to be able to compare it with the "matched but unsettled" ones.

I don't think there is a way to get this information from the existing autopilot metrics so adding this counter to the settle_ok call.

Changes

  • Expose new metric
  • Add settled order count to the settle_ok callback

How to test

See new metrics exposed in prometheus logs

@fleupold fleupold requested a review from a team as a code owner November 7, 2024 16:14
@fleupold fleupold merged commit 822d980 into main Nov 10, 2024
11 checks passed
@fleupold fleupold deleted the metrics/settled_order_count branch November 10, 2024 05:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants