Executed total fee token #2966
Executed total fee token #2966
Conversation
|
Reminder: Please update the DB Readme. Caused by: |
| &total_fee, | ||
| &executed_protocol_fees, | ||
| Asset { | ||
| token: ByteArray(order_fee.total.token.0 .0), |
There was a problem hiding this comment.
Maybe worth having From<TokenAddress> for ByteArray as it appears in more occurrences 🤔
| /// | ||
| /// Denominated in SELL token |
There was a problem hiding this comment.
Do we need this clarification here since the function name is self-explanatory already?
| @@ -0,0 +1,24 @@ | |||
| ALTER TABLE order_execution | |||
| RENAME COLUMN surplus_fee TO total_fee; | |||
There was a problem hiding this comment.
new column is still called total_fee instead of executed_fee in the migration and readme.md.
| ADD COLUMN total_fee_token bytea NOT NULL DEFAULT '\x0000000000000000000000000000000000000000'; | ||
|
|
||
| -- Now populate existing rows with the sell token taken from the 'orders' table, or if it doesn't exist, try from 'jit_orders'. | ||
| UPDATE order_execution oe |
There was a problem hiding this comment.
Did you test that this query does not leave any surplus_token uninitialized?
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
|
Will be worked on in Q4. |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
Description
Implements (1) and (2) from #2963.
Also, renames
surplus_feetototal_feein database.Changes
order_execution.total_fee_tokento databaseexecuted_fee.Note: all places where sell token needs to be substituted with surplus token are marked with
TODO surplus tokenand this will be tackled as part of (3) from #2963.How to test
Existing e2e tests. Observed values during the tests.