[EASY] Remove Observation object #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunce86
commented
Aug 8, 2024
| got: score, | ||
| }) | ||
| .map_err(with(auction_id)); | ||
| } |
There was a problem hiding this comment.
Removed as suggested here: #2861 (comment)
Still dependent on resolving the #2797 as apparently we still have some rounding issues.
squadgazzz
approved these changes
Aug 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracts part of https://github.com/cowprotocol/services/pull/2861/files that can be merged now, and don't have to be part of that PR.
This enables me to have a nice pub interface of
Settlementand continue adding functions for #2862 and not wait for ☝️ PR to be merged.Also #2861 becomes smaller and easier to revert if we encounter some issue on weekly release.