Price improvemenet fee policy autopilot argument #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
approved these changes
Feb 7, 2024
| @@ -380,6 +387,9 @@ impl FeePolicy { | |||
| pub enum FeePolicyKind { | |||
| /// How much of the order's surplus should be taken as a protocol fee. | |||
| Surplus { factor: f64, max_volume_factor: f64 }, | |||
| /// How much of the order's price improvement should be taken as a protocol | |||
There was a problem hiding this comment.
Would be good to define price improvement since this is a bit nuanced.
crates/autopilot/src/arguments.rs
Outdated
| @@ -407,6 +417,22 @@ impl FromStr for FeePolicyKind { | |||
| max_volume_factor, | |||
| }) | |||
| } | |||
| "price-improvement" => { | |||
There was a problem hiding this comment.
I believe we currently tend to prefer camelCase over all so it makes sense to also use it here IMO.
fleupold
approved these changes
Feb 7, 2024
sunce86
approved these changes
Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes task n1 from #2287