Skip to content

Commit

Permalink
Don't underestimate gas cost in verification (#2453)
Browse files Browse the repository at this point in the history
# Description
There are a few operations that we add to a verified quote which
increase the overall gas cost but would not be there during an actual
settlement. That's why gas costs for those operations should be
discounted from the `settle()` call gas cost.
Since we started detecting internal buffer costs we also added more of
those requests which happen before and after the `settle()` call. Since
we only track the gas costs of the `settle()` call discounting those gas
costs will decrease the estimated gas count incorrectly leaving us with
too small gas estimates.

# Changes
Adds a flag to the `store_balance()` helper call that controls which
calls should actually be discounted.

## How to test
CI
  • Loading branch information
MartinquaXD authored Mar 1, 2024
1 parent 1d0d6cf commit fe356a2
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
Loading

0 comments on commit fe356a2

Please sign in to comment.