Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

[Batch Viewer] Fix multiple AMM's interactions not visible #78

Merged
merged 1 commit into from
May 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default class ElementsBuilder {
this._edges.push({
group: 'edges',
data: {
id: `${source.type}:${source.id}->${target.type}:${target.id}`,
id: `${source.type}:${source.id}->${label}->${target.type}:${target.id}`,
source: `${source.type}:${source.id}`,
target: `${target.type}:${target.id}`,
label,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function STYLESHEET(theme: DefaultTheme): Stylesheet[] {
width: 2,
'target-arrow-shape': 'triangle',
'target-arrow-color': theme.grey,
'curve-style': 'unbundled-bezier',
'curve-style': 'bezier',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this change:
image
Before (with: 'curve-style': 'unbundled-bezier' )
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it looks worse but without it you keep having the same reported issue. Could you see if there's a way to make them look similar? Maybe we could suggest merging the 2 arrows into 1 as we discussed.

color: theme.black,
'line-color': theme.grey,
'line-opacity': 0.8,
Expand Down