Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Remove popper when reset, change layout or component unmount #146

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

henrypalacios
Copy link
Contributor

Summary

Closes #143

Remove popper tooltip on mobile when reset, change layout or component unmounted

@github-actions
Copy link

@elena-zh
Copy link

@henrypalacios , great changes!
However, a nitpick: can we close the tooltip as well when open layout dropdown?
image

Thanks!

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrypalacios henrypalacios requested a review from alfetopito June 29, 2022 13:01
@henrypalacios
Copy link
Contributor Author

I will take the liberty of merging so that we can have this PR in the #137 and testing can be done.

@henrypalacios henrypalacios merged commit cbdaa22 into release/2.9.0 Jun 29, 2022
@henrypalacios henrypalacios deleted the 143-tooltip-mobile-error branch June 29, 2022 22:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants