-
Notifications
You must be signed in to change notification settings - Fork 8
[Batch Viewer] Avoid multiple requests to Tenderly API #128
Conversation
|
Pull Request Test Coverage Report for Build 2511187032Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The behaviour described here is working nicely 👍 However, I think I stumbled upon an edge case, which might or might not be related to the changes here. To reproduce:
|
src/apps/explorer/components/SummaryCardsWidget/VolumeChart/VolumeChart.tsx
Outdated
Show resolved
Hide resolved
Hey @alfetopito , I can reproduce this issue only when I open the app for the 1st time. Then, all charts are loaded nicely. |
Indeed, same as I observed. |
@alfetopito It seems it is not related to this PR. The tenderly API is returning 404 for that |
I'm not able to reproduce this issue today |
Summary
Closes #121
Updated Hook in order not to re-render it unnecessarily when there's no changes
To Test
i.e: /rinkeby/tx/0xaa5daa29e997cbf9b6307c707f13c76c3e2cb53ee41b8e85dc3e36e808cbbaf0/?tab=graph
)