Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: various updates #16

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

ckipp01
Copy link
Contributor

@ckipp01 ckipp01 commented Dec 29, 2022

This pr just updates a handful of stuff. The reason is that it was failing in the Steward
Runs
. So this should ensure that the steward plugin doesn't have any issues.

Note that I do rip out some of the custom stuff you have for sonatype publishing and just replace it with
https://github.com/ckipp01/mill-ci-release mainly because it does almost exactly what you were doing in here. Let me know if that's not ok and I can revert it.

This pr just updates a handful of stuff. The reason is that it was
failing in the [Steward
Runs](VirtusLab/scala-steward-repos#98 (comment)).
So this should  ensure that the steward plugin doesn't have any issues.

Note that I do rip out some of the custom stuff you have for sonatype
publishing and just replace it with
https://github.com/ckipp01/mill-ci-release mainly because it does almost
exactly what you were doing in here. Let me know if that's not ok and I
can revert it.
Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ckipp01!

@alexarchambault alexarchambault merged commit 1f361c6 into coursier:master Jan 9, 2023
@ckipp01 ckipp01 deleted the updates branch January 9, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants