Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-12742 quieten jira: macro #799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

osfameron
Copy link
Collaborator

No description provided.

Copy link
Contributor

@simon-dew simon-dew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions:

@@ -43,7 +43,6 @@ function register (registry, context) {
return accum
}, { __DEFAULT__: 'https://issues.couchbase.com/browse' })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit puzzled by this one. If we're removing this extension from the playbook, then why bother updating the extension so it doesn't output to the log? But on the other hand, if you are updating this extension, shouldn't you at least update the default URL?

Suggested change
}, { __DEFAULT__: 'https://issues.couchbase.com/browse' })
}, { __DEFAULT__: 'https://jira.issues.couchbase.com/browse' })

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the output will mean that anyone with a local playbook that still references the extension will now remove the extra noise once they update docs-site.

(If we simply deleted the extension, then it would break local builds.)

As to why not update the default URL... er... no real reason, I just didn't notice, and as nobody uses it, it doesn't seem that important?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, fair enough on the first two points!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants