-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zebra (LOCAL playbook for testing, DO NOT MERGE as it to docs-site) #659
base: master
Are you sure you want to change the base?
Conversation
This playbook uses: - local docs-devex - main worktree in docs-devex/docs-devex - worktrees for: - capella-zebra (component `capella`) - elixir (component `elixir`) - local couchase-cloud (AV-52509-mockup-doc-striping-in-single-branch) with start_paths for: capella (component `capella`) elixir (component `elixir`) NB: nav includes Develop section - local docs-server with (release/7.2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious what the objective is for this playbook and why we're attempting to merge? It seems like we have a lot of local build items still specified and I'd just like to know the context. :)
enterprise: https://www.couchbase.com/products/editions[ENTERPRISE EDITION] | ||
community: https://www.couchbase.com/products/editions[COMMUNITY EDITION] | ||
site-navigation-data-path: _/js/site-navigation-data.js | ||
local-build: HAKIM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want your name to be in this file? Just curious if this was intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I've learnt anything from Banksy, it's that it's important to get your name and branding out there!
But, er, no, that's just a mistake, good catch 😹
ui: | ||
bundle: | ||
# url: https://github.com/couchbase/docs-ui-sandbox/releases/download/prod-146/ui-bundle.zip | ||
url: ../docs-ui/build/ui-bundle.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming we should also change where this points to for the UI bundle.
- ./lib/swagger-ui-block-macro.js | ||
- ./lib/markdown-block.js | ||
- ./lib/tabs-block.js | ||
# - asciidoctor-kroki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still want kroki commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I was building locally on the day that Kroki was unhappy... lemme fix up this PR...
start_path: home | ||
|
||
- url: ../docs-devex/docs-devex/ | ||
worktrees: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this worktrees
attribute for the live site, but understand for testing :)
Actually @sarahlwelton I'll leave this PR as is, it's potentially useful for a local build. Let's create a zebra-staging PR against staging with the same approach. |
See https://github.com/couchbasecloud/couchbase-cloud/pull/18906 and couchbaselabs/docs-devex#14