Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCBC-3678: Docs samples for SDK 3.5 features #321

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

RiPont
Copy link
Contributor

@RiPont RiPont commented Mar 4, 2024

  • Scoped search examples
  • Vector search examples
  • refactored from inline examples to CSPROJ example that compiles.

* Scoped search examples
* Vector search examples
* refactored from inline examples to CSPROJ example that compiles.
ConnectionString = "couchbase://localhost",
UserName = "Administrator",
Password = "password",
EnableDnsSrvResolution = false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: tiny extra "," here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's idiomatic modern C#. :) Compiles just fine.

Copy link
Contributor

@jeffrymorris jeffrymorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Richard -

I think you are missing KV Range Scan and Read from Replica docs. via https://issues.couchbase.com/browse/CBD-5804

Copy link
Contributor

@RichardSmedley RichardSmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RiPont
LGTM

@RichardSmedley RichardSmedley merged commit ca29590 into couchbase:release/3.5 Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants