Incorrect conditions for includeUnpublished

- Incorrect conditions for includeUnpublished
costs-to-expect · Nov 10, 2019 · a769773 · a769773
1 parent 3c40ed5
commit a769773
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/Models/ResourceTypeItemType/Summary/AllocatedExpense.php b/app/Models/ResourceTypeItemType/Summary/AllocatedExpense.php
@@ -438,8 +438,8 @@ public function subcategorySummary(
     private function includeUnpublished($collection, array $parameters): Builder
     {
         if (
-            array_key_exists('include-unpublished', $parameters) === true &&
-            $parameters['include-unpublished'] === true
+            array_key_exists('include-unpublished', $parameters) === false ||
+            $parameters['include-unpublished'] === false
         ) {
             $collection->where(function ($sql) {
                 $sql->whereNull('item_type_allocated_expense.publish_after')->

diff --git a/app/Models/Summary/ItemType/AllocatedExpense.php b/app/Models/Summary/ItemType/AllocatedExpense.php
@@ -420,8 +420,8 @@ public function yearSummary(
     private function includeUnpublished($collection, array $parameters): Builder
     {
         if (
-            array_key_exists('include-unpublished', $parameters) === true &&
-            $parameters['include-unpublished'] === true
+            array_key_exists('include-unpublished', $parameters) === false ||
+            $parameters['include-unpublished'] === false
         ) {
             $collection->where(function ($sql) {
                 $sql->whereNull('item_type_allocated_expense.publish_after')->