some minor cleanup

cosmos · Jan 3, 2025 · 747464b · 747464b
1 parent 8e46750
commit 747464b
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 9 deletions.
diff --git a/e2e/interchaintestv8/relayer_test.go b/e2e/interchaintestv8/relayer_test.go
@@ -70,6 +70,7 @@ func (s *RelayerTestSuite) SetupSuite(ctx context.Context, proofType operator.Su
 	var configInfo relayer.EthCosmosConfigInfo
 	s.Require().True(s.Run("Start Relayer", func() {
 		beaconAPI := ""
+		// The BeaconAPIClient is nil when the testnet is `pow`
 		if eth.BeaconAPIClient != nil {
 			beaconAPI = eth.BeaconAPIClient.GetBeaconAPIURL()
 		}

diff --git a/packages/ethereum/ethereum-light-client/Cargo.toml b/packages/ethereum/ethereum-light-client/Cargo.toml
@@ -28,8 +28,3 @@ hex = { workspace = true }
 
 # Only used for test-utils feature
 milagro_bls = { workspace = true, optional = true }
-
-[dev-dependencies]
-milagro_bls = { workspace = true }
-
-
diff --git a/packages/relayer-lib/src/utils/cosmos.rs b/packages/relayer-lib/src/utils/cosmos.rs
@@ -52,8 +52,6 @@ pub fn target_events_to_timeout_msgs(
 
 /// Converts a list of [`EurekaEvent`]s to a list of [`MsgRecvPacket`]s and
 /// [`MsgAcknowledgement`]s.
-/// # Errors
-/// Returns an error if proof cannot be generated, or membership value is empty for a packet.
 pub fn src_events_to_recv_and_ack_msgs(
     src_events: Vec<EurekaEvent>,
     target_channel_id: &str,
@@ -108,6 +106,9 @@ pub fn src_events_to_recv_and_ack_msgs(
     (recv_msgs, ack_msgs)
 }
 
+/// Generates and injects tendermint proofs for rec, ack and timeout messages.
+/// # Errors
+/// Returns an error a proof cannot be generated for any of the provided messages.
 pub async fn inject_tendermint_proofs(
     recv_msgs: &mut [MsgRecvPacket],
     ack_msgs: &mut [MsgAcknowledgement],

diff --git a/programs/relayer/src/modules/cosmos_to_cosmos.rs b/programs/relayer/src/modules/cosmos_to_cosmos.rs
@@ -113,7 +113,10 @@ impl RelayerService for CosmosToCosmosRelayerModuleServer {
         request: Request<api::RelayByTxRequest>,
     ) -> Result<Response<api::RelayByTxResponse>, tonic::Status> {
         tracing::info!("Handling relay by tx request for cosmos to cosmos...");
+
         let inner_req = request.into_inner();
+        tracing::info!("Got {} source tx IDs", inner_req.source_tx_ids.len());
+        tracing::info!("Got {} timeout tx IDs", inner_req.timeout_tx_ids.len());
         let src_txs = inner_req
             .source_tx_ids
             .into_iter()

diff --git a/programs/relayer/src/modules/cosmos_to_eth.rs b/programs/relayer/src/modules/cosmos_to_eth.rs
@@ -117,9 +117,10 @@ impl RelayerService for CosmosToEthRelayerModuleServer {
         request: Request<api::RelayByTxRequest>,
     ) -> Result<Response<api::RelayByTxResponse>, tonic::Status> {
         tracing::info!("Handling relay by tx request for cosmos to eth...");
+
         let inner_req = request.into_inner();
-        tracing::info!("Got {} source_tx_ids", inner_req.source_tx_ids.len());
-        tracing::info!("Got {} timeout_tx_ids", inner_req.timeout_tx_ids.len());
+        tracing::info!("Got {} source tx IDs", inner_req.source_tx_ids.len());
+        tracing::info!("Got {} timeout tx IDs", inner_req.timeout_tx_ids.len());
         let cosmos_txs = inner_req
             .source_tx_ids
             .into_iter()

diff --git a/programs/relayer/src/modules/eth_to_cosmos.rs b/programs/relayer/src/modules/eth_to_cosmos.rs
@@ -121,7 +121,10 @@ impl RelayerService for EthToCosmosRelayerModuleServer {
         request: Request<api::RelayByTxRequest>,
     ) -> Result<Response<api::RelayByTxResponse>, tonic::Status> {
         tracing::info!("Handling relay by tx request for eth to cosmos...");
+
         let inner_req = request.into_inner();
+        tracing::info!("Got {} source tx IDs", inner_req.source_tx_ids.len());
+        tracing::info!("Got {} timeout tx IDs", inner_req.timeout_tx_ids.len());
         let eth_txs = inner_req
             .source_tx_ids
             .into_iter()