refactor: Remove the use of sdk LegacyMsg

[JulianToledano]

Closes:
#98

This PR replaces the use of sdk.LegacyMsg.GetSigners() in favor of codec.GetMsgV1Signers.

[coderabbitai]

Walkthrough

The recent updates introduce a new plugin-debug target for building a debug version of the Cosmos Hub plugin, alongside modifications in converter.go that streamline import usage, error handling, and the way signers and rosettatypes.Operation instances are managed. Additionally, a previously commented test in converter_test.go has been re-enabled, ensuring the successful conversion of Rosetta operations to transactions is properly verified. These changes aim to enhance debugging capabilities and improve the codebase's efficiency and readability.

Changes

File(s)	Summary
Makefile, plugins/cosmos-hub/makefile	Added a plugin-debug target to build the Cosmos Hub plugin with debug flags.
converter.go	Updated imports, error handling, signers retrieval, and rosettatypes.Operation construction.
converter_test.go	Uncommented TestFromRosettaOpsToTxSuccess to restore test logic for successful conversion.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[github-actions]

@JulianToledano your pull request is missing a changelog!

[raynaudoe]

is there a risk of encountering a nil pointer dereference at any point in this sequence?

[JulianToledano]

It should not, the codec already uses that internally, although we could make a check when initialising rosetta to make sure SigningContext is correctly set.