Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet balance metric occasionally reporting false 0 amounts #1433

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

boojamya
Copy link
Contributor

Our infra team has reported that occasionally the cosmos_relayer_wallet_balance metric falsely reports a balance of 0.

I believe the main culprit here is the ccp.chainProvider.QueryBalance method.

Prior to this PR, we would continue to update the metric even though querying the balance failed.

@boojamya boojamya requested review from jtieri and agouin as code owners March 24, 2024 21:33
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch here, also definitely prefer to pass errors up to the call site instead of logging them and doing nothing like we were before.

@jtieri jtieri enabled auto-merge (squash) March 26, 2024 18:20
@jtieri jtieri merged commit bc46373 into main Mar 26, 2024
22 checks passed
@jtieri jtieri deleted the dan/walBalMetric branch March 26, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants