Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add tombstone field to SlashJailParameters #2433

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

stana-miric
Copy link
Collaborator

@stana-miric stana-miric commented Dec 12, 2024

SlashJailParameters are extended with tombstone field, which indicates whether the validator should be tombstoned when slashed. This parameter will be considered only for double sign infraction, while for downtime will not be used(validator would not be tombstoned)

@stana-miric stana-miric self-assigned this Dec 12, 2024
@github-actions github-actions bot added C:x/provider Assigned automatically by the PR labeler C:Docs Assigned automatically by the PR labeler labels Dec 12, 2024
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Dec 12, 2024
@stana-miric stana-miric marked this pull request as ready for review December 12, 2024 15:23
@stana-miric stana-miric requested a review from a team as a code owner December 12, 2024 15:23
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe add a warning when a user is trying to set the tombstone to true for downtime (something like it has no effect for downtime infraction).

@mpoke mpoke merged commit 67b0fbd into main Dec 20, 2024
19 of 20 checks passed
@mpoke mpoke deleted the smiric/infraction-tombstone-property branch December 20, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Docs Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants