-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: allow the chain id to be updated if the chain has not yet launched #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/provider
Assigned automatically by the PR labeler
label
Oct 29, 2024
insumity
force-pushed
the
insumity/make-chain-id-updateable
branch
from
October 29, 2024 11:03
81907cb
to
a7fa6e6
Compare
21 tasks
insumity
changed the title
fix!: allow the chain id to be updated if the chain has not yet launched
feat!: allow the chain id to be updated if the chain has not yet launched
Oct 29, 2024
mpoke
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM. Just make sure to correctly validate the new chain ID.
insumity
force-pushed
the
insumity/make-chain-id-updateable
branch
from
November 5, 2024 12:14
45d31f6
to
506bb3c
Compare
mpoke
approved these changes
Nov 5, 2024
MSalopek
reviewed
Nov 5, 2024
MSalopek
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:Docs
Assigned automatically by the PR labeler
C:x/provider
Assigned automatically by the PR labeler
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Some consumer chains would like to reserve a
consumerId
but without yet knowing theirchainId
. Currently, to reserve theconsumerId
, you have to send aMsgRegisterConsumer
that also gets thechainId
as a parameter andchainId
cannot later be changed.Solution
Introduce
new_chain_id
inMsgUpdateConsumer
so that a consumer chain can update itschainId
after registration. Note that thechainId
can only be updated before the consumer chain launches.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if the change is state-machine breakingCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
the type prefix if the change is state-machine breaking