-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add version linker flags to make install #1575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
added
type: feature-request
New feature or request improvement
S: ImprovingThings
Improving things: Customer requests, performance improvements, reliability and usability
A:backport/v4.0.x
labels
Jan 19, 2024
mpoke
approved these changes
Jan 19, 2024
sainoe
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
(cherry picked from commit dda626b)
mpoke
pushed a commit
that referenced
this pull request
Jan 19, 2024
chore: add version linker flags to make install (#1575) (cherry picked from commit dda626b) Co-authored-by: MSalopek <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit dda626b)
mpoke
pushed a commit
that referenced
this pull request
Jan 22, 2024
chore: add version linker flags to make install (#1575) (cherry picked from commit dda626b) Co-authored-by: MSalopek <[email protected]>
insumity
pushed a commit
that referenced
this pull request
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:Build
Assigned automatically by the PR labeler
S: ImprovingThings
Improving things: Customer requests, performance improvements, reliability and usability
type: feature-request
New feature or request improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
This PR enables showing version information for ICS test apps.
e.g.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...