Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add version linker flags to make install #1575

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

MSalopek
Copy link
Contributor

Description

Closes: #XXXX

This PR enables showing version information for ICS test apps.

e.g.

$: interchain-security-cdd version
main-bd5b1ef2c4e3053b18083382c2dd853b0042c85e

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@MSalopek MSalopek added type: feature-request New feature or request improvement S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability A:backport/v4.0.x labels Jan 19, 2024
@MSalopek MSalopek self-assigned this Jan 19, 2024
@MSalopek MSalopek requested a review from a team as a code owner January 19, 2024 15:16
@github-actions github-actions bot added the C:Build Assigned automatically by the PR labeler label Jan 19, 2024
@mpoke mpoke enabled auto-merge January 19, 2024 16:50
@sainoe sainoe self-requested a review January 19, 2024 17:05
Copy link
Contributor

@sainoe sainoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mpoke mpoke added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit dda626b Jan 19, 2024
12 checks passed
@mpoke mpoke deleted the masa/linker-flags branch January 19, 2024 17:08
mergify bot pushed a commit that referenced this pull request Jan 19, 2024
mpoke pushed a commit that referenced this pull request Jan 19, 2024
chore: add version linker flags to make install (#1575)

(cherry picked from commit dda626b)

Co-authored-by: MSalopek <[email protected]>
mergify bot pushed a commit that referenced this pull request Jan 22, 2024
mpoke pushed a commit that referenced this pull request Jan 22, 2024
chore: add version linker flags to make install (#1575)

(cherry picked from commit dda626b)

Co-authored-by: MSalopek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Build Assigned automatically by the PR labeler S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability type: feature-request New feature or request improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants