-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add key assignment to model and driver #1573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @p-offtermatt. Partial review without ccv_model.qnt. See my comments below. In general, try to either comment large blocks of quint or split the blocks -- it's very hard for me (Quint beginner) to read it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I focused my review on the Quint code.
I concur with Mariu's comment in regards to introducing more comments in general.
Two last comments:
- I'm not sure if it would simplify the model in not considering
0
powers. If I understood correctly from our discussion, this stems from ABCI which might be too implementation specific. If it doesn't simplify, then it's fine to leave as is. - Now
addr
andkey
seem to be used interchangeably in names. Would it make sense to stick with one for consistency?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @p-offtermatt.
Description
Closes: #1529
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...