feat: Equivocation gov proposal (#703)

This change adds a new kind of gov proposal that will slash and tombstone validators for double-signing. The proposal handler is added in the `provider` module, and use the `evidence` module to handle the equivocations. Co-authored-by: Albert Le Batteux <[email protected]> Co-authored-by: Jehan <[email protected]>
cosmos · Feb 6, 2023 · 50957d0 · 50957d0
1 parent cbe4331
commit 50957d0
Show file tree

Hide file tree

Showing 17 changed files with 835 additions and 185 deletions.
diff --git a/Makefile b/Makefile
@@ -96,6 +96,7 @@ SDK_QUERY 			= third_party/proto/cosmos/base/query/v1beta1
 SDK_BASE 			= third_party/proto/cosmos/base/v1beta1
 SDK_UPGRADE			= third_party/proto/cosmos/upgrade/v1beta1
 SDK_STAKING			= third_party/proto/cosmos/staking/v1beta1
+SDK_EVIDENCE		= third_party/proto/cosmos/evidence/v1beta1
 
 GOGO_PROTO_TYPES    = third_party/proto/gogoproto
 CONFIO_TYPES        = third_party/proto/confio
@@ -117,6 +118,9 @@ proto-update-deps:
 	@mkdir -p $(SDK_STAKING)
 	@curl -sSL $(SDK_PROTO_URL)/staking/v1beta1/staking.proto > $(SDK_STAKING)/staking.proto
 
+	@mkdir -p $(SDK_EVIDENCE)
+	@curl -sSL $(SDK_PROTO_URL)/evidence/v1beta1/evidence.proto > $(SDK_EVIDENCE)/evidence.proto
+
 ## Importing of tendermint protobuf definitions currently requires the
 ## use of `sed` in order to build properly with cosmos-sdk's proto file layout
 ## (which is the standard Buf.build FILE_LAYOUT)

diff --git a/app/provider/app.go b/app/provider/app.go
@@ -147,6 +147,7 @@ var (
 			ibcclientclient.UpgradeProposalHandler,
 			ibcproviderclient.ConsumerAdditionProposalHandler,
 			ibcproviderclient.ConsumerRemovalProposalHandler,
+			ibcproviderclient.EquivocationProposalHandler,
 		),
 		params.AppModuleBasic{},
 		crisis.AppModuleBasic{},
@@ -421,6 +422,14 @@ func New(
 		scopedIBCKeeper,
 	)
 
+	// create evidence keeper with router
+	app.EvidenceKeeper = *evidencekeeper.NewKeeper(
+		appCodec,
+		keys[evidencetypes.StoreKey],
+		app.StakingKeeper,
+		app.SlashingKeeper,
+	)
+
 	app.ProviderKeeper = ibcproviderkeeper.NewKeeper(
 		appCodec,
 		keys[providertypes.StoreKey],
@@ -433,6 +442,7 @@ func New(
 		app.StakingKeeper,
 		app.SlashingKeeper,
 		app.AccountKeeper,
+		app.EvidenceKeeper,
 		authtypes.FeeCollectorName,
 	)
 
@@ -446,7 +456,7 @@ func New(
 		AddRoute(distrtypes.RouterKey, distr.NewCommunityPoolSpendProposalHandler(app.DistrKeeper)).
 		AddRoute(upgradetypes.RouterKey, upgrade.NewSoftwareUpgradeProposalHandler(app.UpgradeKeeper)).
 		AddRoute(ibchost.RouterKey, ibcclient.NewClientProposalHandler(app.IBCKeeper.ClientKeeper)).
-		AddRoute(providertypes.RouterKey, ibcprovider.NewConsumerChainProposalHandler(app.ProviderKeeper)).
+		AddRoute(providertypes.RouterKey, ibcprovider.NewProviderProposalHandler(app.ProviderKeeper)).
 		AddRoute(ibcclienttypes.RouterKey, ibcclient.NewClientProposalHandler(app.IBCKeeper.ClientKeeper))
 
 	app.GovKeeper = govkeeper.NewKeeper(
@@ -479,16 +489,6 @@ func New(
 	ibcRouter.AddRoute(providertypes.ModuleName, providerModule)
 	app.IBCKeeper.SetRouter(ibcRouter)
 
-	// create evidence keeper with router
-	evidenceKeeper := evidencekeeper.NewKeeper(
-		appCodec,
-		keys[evidencetypes.StoreKey],
-		app.StakingKeeper,
-		app.SlashingKeeper,
-	)
-
-	app.EvidenceKeeper = *evidenceKeeper
-
 	skipGenesisInvariants := cast.ToBool(appOpts.Get(crisis.FlagSkipGenesisInvariants))
 
 	// NOTE: Any module instantiated in the module manager that is later modified

diff --git a/proto/interchain_security/ccv/provider/v1/provider.proto b/proto/interchain_security/ccv/provider/v1/provider.proto
@@ -10,6 +10,7 @@ import "google/protobuf/duration.proto";
 import "ibc/core/client/v1/client.proto";
 import "ibc/lightclients/tendermint/v1/tendermint.proto";
 import "tendermint/crypto/keys.proto";
+import "cosmos/evidence/v1beta1/evidence.proto";
 
 // ConsumerAdditionProposal is a governance proposal on the provider chain to spawn a new consumer chain.
 // If it passes, then all validators on the provider chain are expected to validate the consumer chain at spawn time
@@ -77,6 +78,15 @@ message ConsumerRemovalProposal {
         [(gogoproto.stdtime) = true, (gogoproto.nullable) = false];
  } 
 
+message EquivocationProposal {
+  // the title of the proposal
+  string title = 1;
+  // the description of the proposal
+  string description = 2;
+	// the list of equivocations that will be processed
+  repeated cosmos.evidence.v1beta1.Equivocation equivocations = 3;
+}
+
 // A persisted queue entry indicating that a slash packet data instance needs to be handled.
 // This type belongs in the "global" queue, to coordinate slash packet handling times between consumers.
 message GlobalSlashEntry {

diff --git a/testutil/keeper/mocks.go b/testutil/keeper/mocks.go
diff --git a/testutil/keeper/unit_test_helpers.go b/testutil/keeper/unit_test_helpers.go
@@ -86,6 +86,7 @@ type MockedKeepers struct {
 	*MockBankKeeper
 	*MockIBCTransferKeeper
 	*MockIBCCoreKeeper
+	*MockEvidenceKeeper
 }
 
 // NewMockedKeepers instantiates a struct with pointers to properly instantiated mocked keepers.
@@ -102,12 +103,12 @@ func NewMockedKeepers(ctrl *gomock.Controller) MockedKeepers {
 		MockBankKeeper:        NewMockBankKeeper(ctrl),
 		MockIBCTransferKeeper: NewMockIBCTransferKeeper(ctrl),
 		MockIBCCoreKeeper:     NewMockIBCCoreKeeper(ctrl),
+		MockEvidenceKeeper:    NewMockEvidenceKeeper(ctrl),
 	}
 }
 
 // NewInMemProviderKeeper instantiates an in-mem provider keeper from params and mocked keepers
 func NewInMemProviderKeeper(params InMemKeeperParams, mocks MockedKeepers) providerkeeper.Keeper {
-
 	return providerkeeper.NewKeeper(
 		params.Cdc,
 		params.StoreKey,
@@ -120,13 +121,13 @@ func NewInMemProviderKeeper(params InMemKeeperParams, mocks MockedKeepers) provi
 		mocks.MockStakingKeeper,
 		mocks.MockSlashingKeeper,
 		mocks.MockAccountKeeper,
+		mocks.MockEvidenceKeeper,
 		"",
 	)
 }
 
 // NewInMemConsumerKeeper instantiates an in-mem consumer keeper from params and mocked keepers
 func NewInMemConsumerKeeper(params InMemKeeperParams, mocks MockedKeepers) consumerkeeper.Keeper {
-
 	return consumerkeeper.NewKeeper(
 		params.Cdc,
 		params.StoreKey,
@@ -150,8 +151,8 @@ func NewInMemConsumerKeeper(params InMemKeeperParams, mocks MockedKeepers) consu
 // Note: Calling ctrl.Finish() at the end of a test function ensures that
 // no unexpected calls to external keepers are made.
 func GetProviderKeeperAndCtx(t *testing.T, params InMemKeeperParams) (
-	providerkeeper.Keeper, sdk.Context, *gomock.Controller, MockedKeepers) {
-
+	providerkeeper.Keeper, sdk.Context, *gomock.Controller, MockedKeepers,
+) {
 	ctrl := gomock.NewController(t)
 	mocks := NewMockedKeepers(ctrl)
 	return NewInMemProviderKeeper(params, mocks), params.Ctx, ctrl, mocks
@@ -162,8 +163,8 @@ func GetProviderKeeperAndCtx(t *testing.T, params InMemKeeperParams) (
 // Note: Calling ctrl.Finish() at the end of a test function ensures that
 // no unexpected calls to external keepers are made.
 func GetConsumerKeeperAndCtx(t *testing.T, params InMemKeeperParams) (
-	consumerkeeper.Keeper, sdk.Context, *gomock.Controller, MockedKeepers) {
-
+	consumerkeeper.Keeper, sdk.Context, *gomock.Controller, MockedKeepers,
+) {
 	ctrl := gomock.NewController(t)
 	mocks := NewMockedKeepers(ctrl)
 	return NewInMemConsumerKeeper(params, mocks), params.Ctx, ctrl, mocks
@@ -219,8 +220,8 @@ func GetNewVSCMaturedPacketData() ccvtypes.VSCMaturedPacketData {
 // SetupForStoppingConsumerChain registers expected mock calls and corresponding state setup
 // which asserts that a consumer chain was properly stopped from StopConsumerChain().
 func SetupForStoppingConsumerChain(t *testing.T, ctx sdk.Context,
-	providerKeeper *providerkeeper.Keeper, mocks MockedKeepers) {
-
+	providerKeeper *providerkeeper.Keeper, mocks MockedKeepers,
+) {
 	expectations := GetMocksForCreateConsumerClient(ctx, &mocks,
 		"chainID", clienttypes.NewHeight(4, 5))
 	expectations = append(expectations, GetMocksForSetConsumerChain(ctx, &mocks, "chainID")...)