chore: code reduction on doHash #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Oct 7, 2024
| return nil, err | ||
| } | ||
| return blakeHash.Sum(nil), nil | ||
| // TODO: there doesn't seem to be an "official" implementation of BLAKE3 in Go, |
There was a problem hiding this comment.
took the liberty of removing this comment. If desired, someone can open an issue
colin-axner
commented
Oct 7, 2024
| @@ -190,41 +190,17 @@ func doHash(hashOp HashOp, preimage []byte) ([]byte, error) { | |||
| return hashBz(crypto.RIPEMD160, preimage) | |||
| case HashOp_BITCOIN: | |||
There was a problem hiding this comment.
wasn't mentioned in the audit, but I added code reduction here as well
damiannolan
approved these changes
Oct 8, 2024
DimitrisJim
approved these changes
Oct 9, 2024
|
Might need to push an empty commit to this to trigger CI required check! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.