remove capability authentication checks in core handlers that are routed from ICS 26 #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this r4r? |
crodriguezvega
requested review from
mpoke,
AdityaSripal,
cwgoes,
angbrav and
colin-axner
as code owners
added 2 commits
October 2, 2023 13:41
…hentication-from-ics-026-routed-handlers
…hentication-from-ics-026-routed-handlers
…hentication-from-ics-026-routed-handlers
|
I will close this PR, but keep the branch for now. I might be able to reuse it for #1133. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #886
I have also updated all the
onChanOpenInitandonChanOpenTrycallbacks to receive the channel capability as an argument and adapted the implementation of the callbacks to claim the channel capability where required.