use new port router with OnAcknowledgementPacket #7108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Aug 8, 2024
colin-axner
commented
Aug 8, 2024
colin-axner
requested review from
AdityaSripal,
damiannolan,
srdtrk and
chatton
as code owners
colin-axner
commented
Aug 8, 2024
| panic(errorsmod.Wrap(err, "failed to unwrap acknowledgement")) | ||
| } | ||
|
|
||
| return ack, incentivizedAck.AppAcknowledgement |
There was a problem hiding this comment.
note: we return ack we unmarshaled as our ack. This is because it expects to unmarshal this value in OnAcknowledgement
|
chatton
approved these changes
Aug 8, 2024
| ctx sdk.Context, | ||
| channelVersion string, | ||
| packet channeltypes.Packet, | ||
| acknowledgement []byte, | ||
| relayer sdk.AccAddress, | ||
| ) error { | ||
| for i := len(im.cbs) - 1; i >= 0; i-- { |
There was a problem hiding this comment.
this ended up looking super clean with these 2 interfaces for wrapping, nice job!
|
|
||
| // AcknowledgementWrapper is an optional interface which should be implemented by middlewares which wrap the acknowledgement | ||
| // to ensure backwards compatibility. | ||
| type AcknowledgementWrapper interface { |
There was a problem hiding this comment.
I think we can add a type assertion for ics29
| @@ -131,12 +131,29 @@ type VersionWrapper interface { | |||
| WrapVersion(cbVersion, underlyingAppVersion string) string | |||
| // UnwrapVersionUnsafe is required in order to remove middleware wiring and the ICS4Wrapper | |||
| // while maintaining backwards compatibility. It will be removed in the future. | |||
| // Applications should unwrap the provided version with into their application version. | |||
| // Applications should unwrap the provided version with into their application version. | |||
| // and the underlying application version. If they are unsuccessful they should return an error. | |||
| // UnwrapVersionUnsafe will be used during opening handshakes and channel upgrades when the version | |||
| // is still being negotiated. | |||
| UnwrapVersionUnsafe(string) (cbVersion, underlyingAppVersion string, err error) | |||
There was a problem hiding this comment.
I think we can add a type assertion for ics27
…n/7031-portrouter-onacknowledgementpacket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7031
ref: #7043
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.