test: add unwind + forwarding to sender test #6905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishal-kanna
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
There was a problem hiding this comment.
Thank you for the PR, @vishal-kanna. The test you added in this PR is not exactly what was meant in the issue. You should take a look at the tests in relay_forwarding_test.go. The idea is to write an integration test like those. The setup of the test should send tokens from A to B and then on B we should set forwarding to types.NewForwarding(true, types.NewHop(pathAtoB.EndpointA.ChannelConfig.PortID, pathAtoB.EndpointA.ChannelID)). This basically will send the tokens first back to A (unwind them) and them forward them back to chain B. Let us know if you have questions or need any help. Taking the tests in the file I mentioned as reference about should give you an idea of how to write the test.
crodriguezvega
changed the title
crodriguezvega
requested review from
DimitrisJim,
gjermundgaraba and
bznein
as code owners
bznein
approved these changes
Aug 9, 2024
| @@ -56,7 +56,7 @@ func ParseChannelIDFromEvents(events []abci.Event) (string, error) { | |||
| return "", errors.New("channel identifier event attribute not found") | |||
| } | |||
|
|
|||
| // ParsePacketFromEvents parses events emitted from a MsgRecvPacket and returns | |||
| // ParsePacketFromEvents parses events emitted from a send packet and returns | |||
Co-authored-by: Nikolas De Giorgis <[email protected]>
colin-axner
approved these changes
Aug 12, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
* chore: added unit test * chore: added unit test * wip * take test to finish line * Update modules/apps/transfer/keeper/relay_forwarding_test.go Co-authored-by: Nikolas De Giorgis <[email protected]> * fix typo --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Nikolas De Giorgis <[email protected]> (cherry picked from commit 3f34f29)
crodriguezvega
added a commit
that referenced
this pull request
Aug 14, 2024
* chore: added unit test * chore: added unit test * wip * take test to finish line * Update modules/apps/transfer/keeper/relay_forwarding_test.go Co-authored-by: Nikolas De Giorgis <[email protected]> * fix typo --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Nikolas De Giorgis <[email protected]> (cherry picked from commit 3f34f29) Co-authored-by: Vishal Potpelliwar <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6878