Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make UnmarshalPacketData public #6897

Merged
merged 2 commits into from
Jul 22, 2024
Merged

chore: make UnmarshalPacketData public #6897

merged 2 commits into from
Jul 22, 2024

Conversation

gjermundgaraba
Copy link
Contributor

Description

closes: #6880

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba gjermundgaraba linked an issue Jul 19, 2024 that may be closed by this pull request
Make transfer UnmarshalPacketData a public func #6880
Closed
3 tasks
@crodriguezvega crodriguezvega added priority PRs that need prompt reviews backport-to-v9.0.x labels Jul 19, 2024
crodriguezvega
crodriguezvega approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, @gjermundgaraba!

@gjermundgaraba gjermundgaraba enabled auto-merge July 19, 2024 13:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gjermundgaraba gjermundgaraba added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit bb9d12c Jul 22, 2024
67 of 69 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/6880-make-transfer-unmarshalpacketdata-a-public-func branch July 22, 2024 12:14
mergify bot pushed a commit that referenced this pull request Jul 22, 2024
@gjermundgaraba @mergify
chore: make UnmarshalPacketData public (#6897)
719fec8 
(cherry picked from commit bb9d12c)
@mergify mergify bot mentioned this pull request Jul 22, 2024
Merged
10 tasks
crodriguezvega pushed a commit that referenced this pull request Jul 23, 2024
@mergify @gjermundgaraba
chore: make UnmarshalPacketData public (#6897) (#6913)
f93c7ce 
(cherry picked from commit bb9d12c)

Co-authored-by: Gjermund Garaba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@damiannolan damiannolan damiannolan approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
backport-to-v9.0.x priority PRs that need prompt reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make transfer UnmarshalPacketData a public func
4 participants
@gjermundgaraba @damiannolan @crodriguezvega @DimitrisJim