Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved the CONTRACT godoc to doc.go #6894

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

vishal-kanna
Copy link
Contributor

@vishal-kanna vishal-kanna commented Jul 19, 2024

closes: #6881

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vishal-kanna!

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgt but see nit (added for solomachine but same elsewhere probably)

@DimitrisJim DimitrisJim enabled auto-merge July 19, 2024 09:55
@crodriguezvega crodriguezvega added backport-to-v9.0.x priority PRs that need prompt reviews labels Jul 21, 2024
@damiannolan damiannolan self-assigned this Jul 22, 2024
@DimitrisJim DimitrisJim added this pull request to the merge queue Jul 22, 2024
Merged via the queue into cosmos:main with commit dab878e Jul 22, 2024
78 of 79 checks passed
mergify bot pushed a commit that referenced this pull request Jul 22, 2024
* chore: moved the CONTRACT godoc to doc.go

* chore: made review changes

* chore: clean up doc.go files.

* chore: update doc.go of light client modules

---------

Co-authored-by: DimitrisJim <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit dab878e)

# Conflicts:
#	modules/light-clients/06-solomachine/light_client_module.go
#	modules/light-clients/07-tendermint/light_client_module.go
damiannolan pushed a commit that referenced this pull request Jul 23, 2024
* chore: moved the CONTRACT godoc to doc.go (#6894)

* chore: moved the CONTRACT godoc to doc.go

* chore: made review changes

* chore: clean up doc.go files.

* chore: update doc.go of light client modules

---------

Co-authored-by: DimitrisJim <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit dab878e)

# Conflicts:
#	modules/light-clients/06-solomachine/light_client_module.go
#	modules/light-clients/07-tendermint/light_client_module.go

* fix conflicts

---------

Co-authored-by: Vishal Potpelliwar <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: DimitrisJim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v9.0.x priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move CONTRACT doc strings on light client module functions to doc.go
4 participants