Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tm prefixed packages to cmt #5158

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Nov 22, 2023

Description

🧹 trigger inspiration #5079 (comment)

closes: #4184

Commit Message / Changelog Entry

chore: rename tm prefixed packages to cmt.

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Merging #5158 (46cd4f5) into main (4bb8edd) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5158   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files         189      189           
  Lines       13260    13260           
=======================================
  Hits        10548    10548           
  Misses       2292     2292           
  Partials      420      420           
Files Coverage Δ
modules/apps/transfer/keeper/keeper.go 93.15% <100.00%> (ø)
modules/apps/transfer/types/trace.go 89.85% <100.00%> (ø)
modules/core/23-commitment/types/merkle.go 68.18% <ø> (ø)
...odules/light-clients/07-tendermint/client_state.go 91.80% <100.00%> (ø)
...les/light-clients/07-tendermint/consensus_state.go 100.00% <100.00%> (ø)
modules/light-clients/07-tendermint/fraction.go 100.00% <100.00%> (ø)
modules/light-clients/07-tendermint/header.go 100.00% <100.00%> (ø)
...odules/light-clients/07-tendermint/misbehaviour.go 70.37% <100.00%> (ø)
...light-clients/07-tendermint/misbehaviour_handle.go 85.43% <100.00%> (ø)
modules/light-clients/07-tendermint/update.go 87.50% <100.00%> (ø)

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chatton chatton mentioned this pull request Nov 22, 2023
9 tasks
@DimitrisJim DimitrisJim enabled auto-merge (squash) November 22, 2023 12:47
@DimitrisJim DimitrisJim merged commit 0e3f428 into main Nov 22, 2023
77 checks passed
@DimitrisJim DimitrisJim deleted the jim/4184-replace-tm-with-cmt branch November 22, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02-client 04-channel 07-tendermint 08-wasm 20-transfer capability Issues for capability modules core e2e testing Testing package and unit/integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace tm prefix with cmt prefix
5 participants