chore: add hidden folders to codespell + fail on pr (#7808)

* chore: add hidden folders to codespell

* add .github to codespell

* fail code spell checker on PRs

* fix spelling error in e2e gh action

.github/workflows/e2e.yaml

@@ -65,6 +65,6 @@ jobs:
       chain-a-tag: '${{ needs.determine-image-tag.outputs.simd-tag }}'
       chain-b-tag: '${{ needs.determine-image-tag.outputs.simd-tag }}'
       # on regular PRs we won't run upgrade tests.
-      # NOTE: we are exluding TestTransferTestSuite as we run this full suite instead of each individual test.
+      # NOTE: we are excluding TestTransferTestSuite as we run this full suite instead of each individual test.
       test-exclusions: 'TestUpgradeTestSuite,TestIBCWasmUpgradeTestSuite,TestTransferTestSuite,TestAuthzTransferTestSuite,TestTransferTestSuiteSendReceive,TestTransferTestSuiteSendEnabled,TestTransferLocalhostTestSuite,TestConnectionTestSuite,TestInterchainAccountsGovTestSuite,TestIncentivizedTransferTestSuite,TestTransferForwardingTestSuite'
       temp-run-full-suite: true

.github/workflows/spell-checker.yml

@@ -22,8 +22,8 @@ jobs:
       - name: Install codespell
         run: pip install codespell
       - name: Run codespell
-        continue-on-error: true
-        run: codespell -w --skip="*.pb.go,*.pb.gw.go,*.json,*.git,*.js,*.h,*.bin,go.sum,go.mod,.github,*.pdf,*.tla" --ignore-words=.github/.codespellignore
+        continue-on-error: ${{ github.event_name != 'pull_request' }}
+        run: codespell -w --skip="*.pb.go,*.pb.gw.go,*.json,*.git,*.js,*.h,*.bin,go.sum,go.mod,*.pdf,*.tla" --ignore-words=.github/.codespellignore --check-hidden
       - uses: peter-evans/create-pull-request@v7
         if: github.event_name != 'pull_request'
         with:

modules/core/04-channel/keeper/upgrade_test.go

@@ -2492,8 +2492,8 @@ func (suite *KeeperTestSuite) TestAbortUpgrade() {
 				errorReceipt, found := channelKeeper.GetUpgradeErrorReceipt(suite.chainA.GetContext(), path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)
 				suite.Require().True(found, "error receipt should be found")
 
-				if ue, ok := upgradeError.(*types.UpgradeError); ok {
-					suite.Require().Equal(ue.GetErrorReceipt(), errorReceipt, "error receipt does not match expected error receipt")
+				if upgradeError, ok := upgradeError.(*types.UpgradeError); ok {
+					suite.Require().Equal(upgradeError.GetErrorReceipt(), errorReceipt, "error receipt does not match expected error receipt")
 				}
 			} else {