chore(core, solomachine)!: remove TypeClientMisbehaviour and Type met…

…hod on Misbehaviour (#6888)

* chore(core, solomachine)remove TypeClientMisbehaviour and the Type method on Misbehaviour

* Update CHANGELOG.md

* docs: add to migration docs.

CHANGELOG.md

@@ -65,6 +65,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (core, core/02-client) [\#6763](https://github.com/cosmos/ibc-go/pull/6763) Move prometheus metric labels for 02-client and core into a separate `metrics` package on core.
 * (core/02-client) [\#6777](https://github.com/cosmos/ibc-go/pull/6777) The `NewClientProposalHandler` of `02-client` has been removed.
 * (core/types) [\#6794](https://github.com/cosmos/ibc-go/pull/6794) The composite interface `QueryServer` has been removed from package `core/types`. Please use the granular `QueryServer` interfaces provided by each core submodule.
+* (light-clients/06-solomachine) [\#6888](https://github.com/cosmos/ibc-go/pull/6888) Remove `TypeClientMisbehaviour` constant and the `Type` method on `Misbehaviour`.
 
 ### State Machine Breaking
 

docs/docs/05-migrations/13-v8-to-v9.md

@@ -124,6 +124,7 @@ The base application is then set by default to nil and thus authentication is as
 - The function `CreateLocalhostClient` has been removed. The localhost client is now stateless. 
 - The function `NewClientProposalHandler` has been removed. [#6777](https://github.com/cosmos/ibc-go/pull/6777).
 - The composite interface `QueryServer` has been removed from package `core/types`. Please use the granular `QueryServer` interfaces for ibc submodules directly.
+- The `TypeClientMisbehaviour` constant has been removed.
 
 ### 02-client
 
@@ -202,7 +203,8 @@ Please check also the [Light client developer guide](../03-light-clients/01-deve
 
 ### 06-solomachine
 
-The `Initialize`, `Status`, `GetTimestampAtHeight` and `UpdateStateOnMisbehaviour` functions in `ClientState` have been removed and all their logic has been moved to functions of the `LightClientModule`.
+- The `Initialize`, `Status`, `GetTimestampAtHeight` and `UpdateStateOnMisbehaviour` functions in `ClientState` have been removed and all their logic has been moved to functions of the `LightClientModule`.
+- The `Type` method on `Misbehaviour` has been removed.
 
 ### 07-tendermint
 

modules/core/exported/client.go

@@ -10,9 +10,6 @@ import (
 type Status string
 
 const (
-	// TypeClientMisbehaviour is the shared evidence misbehaviour type
-	TypeClientMisbehaviour string = "client_misbehaviour"
-
 	// Solomachine is used to indicate that the light client is a solo machine.
 	Solomachine string = "06-solomachine"
 

modules/light-clients/06-solomachine/misbehaviour.go

@@ -16,11 +16,6 @@ func (Misbehaviour) ClientType() string {
 	return exported.Solomachine
 }
 
-// Type implements Misbehaviour interface.
-func (Misbehaviour) Type() string {
-	return exported.TypeClientMisbehaviour
-}
-
 // ValidateBasic implements Misbehaviour interface.
 func (misbehaviour Misbehaviour) ValidateBasic() error {
 	if misbehaviour.Sequence == 0 {