feat: add storage leak test #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
packet-forward-middleware
agouin
approved these changes
Nov 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
* feat: add storage leak test * cleanup test * add e2e to workflow (cherry picked from commit 64c5cd5)
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
* feat: add storage leak test * cleanup test * add e2e to workflow (cherry picked from commit 64c5cd5) # Conflicts: # .github/workflows/packet-forward-middleware.yml # middleware/packet-forward-middleware/Makefile
joelsmith-2019
added a commit
that referenced
this pull request
Nov 22, 2024
* feat: add storage leak test (#222) * feat: add storage leak test * cleanup test * add e2e to workflow (cherry picked from commit 64c5cd5) * Fix Deps * Fix NewSimApp Options --------- Co-authored-by: Joel Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, flight packets were retained in the module's storage after a packet timeout. Now, flight packets are correctly removed when they timeout. An additional test was also added to verify that flight packets are correctly removed and not retained in storage after a timeout.