Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Quarantine and Sanction modules #18535

Closed

Conversation

SpicyLemon
Copy link
Collaborator

@SpicyLemon SpicyLemon commented Nov 21, 2023

Description

Sorry. Forgot to change the fork before submitting this. Please ignore it.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

SpicyLemon and others added 30 commits July 27, 2022 13:20
* Merge pull request #175 from provenance-io/prov/limit-authz-uses

Create a new authz authorization type that is limited to a certain number of times

* register CountAuthorization interface with registry (#194)

* add changelog entry.

Co-authored-by: Ergels Gaxhaj <[email protected]>
…grade-order-fix

Revert PR206: Upgrade Order Fix.
…ges (backport cosmos#12615) (cosmos#12792)

* feat: Add GetParamSetIfExists to prevent panic on breaking param changes (cosmos#12615)

* imp(params): Add GetParamSetIfExists to prevent panic on breaking param changes

* changelog

* test

Co-authored-by: Marko <[email protected]>
(cherry picked from commit 2932e11)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Marko <[email protected]>
* feat(bank)!: Move the bank module SendEnabled info into state (from Params). (cosmos#11977)

* go mod tidy everything.

* Add some third_party proto files that are imported but not included.

* [11859]: Add a new key for the SendEnabled flags and keeper methods for getting, setting, and deleting them.

* [11859]: Remove the send_enabled field from the bank Params proto.

* Revert "Add some third_party proto files that are imported but not included."

This reverts commit 8b7acf8.

* [11859]: Regenerate the bank params stuff from the changed proto.

* [11859]: Add a send_enabled field to the bank genesis proto.

* Revert "[11859]: Remove the send_enabled field from the bank Params proto."

This reverts commit 0bd904c.

* Revert "[11859]: Regenerate the bank params stuff from the changed proto."

This reverts commit 33d4652.

* [11859]: Deprecate the bank Params send_enabled field.

* [11859]: Regenerate the bank go code from the updated protos.

* [11859]: Reduce the number of times the store is recreated during IsSendEnabledCoins. Store creation has some overhead.

* [11859]: Add the SendEnabled stuff to the genesis methods. Make a couple TODO notes. Create a way to iterate over the SendEnabled entries and get all of them.

* [11859]: Update the bank sim genesis stuff to create random SendEnabled entries similar to when they were params.

* Remove some of the bank params methods that are no longer meaningful.

* Add a comment about why we're calling a mutation method in a Validate function.

* [11859]: Add some more TODO notes and make the SendEnabled.String() function significantlly simpler.

* [11859]: Get rid of the SendEnabledParams type.

* Fix up a few comments.

* [11859]: Update the bank keeper test due to recent changes.

* [11859]: Tweak the bank Params and SendEnabled String funcs. Params no longer returns {} when there aren't any SendEnabled entries and the default is false. SendEnabled is back to outputting a yaml format.

* [11859]: Fix the params tests and add some new ones to it and key_test.

* [11859]: Create a 1-store method for updating several SendEnabled entries at once.

* [11859]: Create a migration for both the module and genesis state.

* [11859]: Create a new MsgSetSendEnabled for governanance proposals to set SendEnabled.

* [11859]: Add SetAllSendEnabled to the SendKeeper interface.

* [11859]: Add an authority to the bank keeper and create the handler for MsgSetSendEnabled.

* [11859]: Add an rpc endpoint for querying SendEnabled.

* [11859]: Implement the SendEnabled query.

* [11859]: Add a function for decoding a --page-key base64 value so that pagination can work as expected.

* [11859]: Implement a CLI command for querying SendEnabled.

* [11859]: Move the v047 store migration stuff into Migrate3to4 directly to prevent a circular dependency between 047 and the keeper. Not using the keeper for that would be a significant pain in the butt.

* [11869]: Implement the Msg interface for MsgSetSendEnabled.

* [11859]: Fix some unit tests that I broke along the way.

* [11859]: Reorg the funcs added to the SendKeeper interface.

* [11859]: Fix the return values of a couple of the MsgSetSendEnabled LegacyMsg funcs.

* [11859]: Tweak MigrateSendEnabled to add stuff to the existing slice (if there's anything to add). And then use that in the MigrateGenState function.

* [11859]: Don't set the Pagination field when looking up specific entries.

* [11859]: Put validateSendEnabledParams back to the way it was to allow reading the old Params without error.

* [11859]: Write up a bunch of unit tests.

* [11859]: Update the MsgSetSendEnabled.ValidateBasic() function with some extra failure points. Write up some tests.

* Update a test I fixed then broke.

* [11859]: Have the run-tests make target exit with a non-zero status if any of the tests fail.

* [11859]: Add changelog entries.

* [11859]: Add a missing func comment.

* [11859]: Only do a couple assertions if the elements exist to do so.

* [11859]: Add some more missing function comments.

* [11859]: Update the bank spec documentation.

* [11859]: Change name of WithPageKeyDecoded to FlagSetWithPageKeyDecoded, have it return an error and make MustFlagSetWithPageKeyDecoded for the one-liner.

* [11859]: Update the documentation on the SendEnabled query.

* [11859]: Add final newline to query.proto.

* [11859]: Remove the SetSendEnabled msg and endpoint.

* [11859]: Use nil instead of an empty slice of SendEnabled for defaults and where called for.

* [11859]: Update SetParams to migrate entries too.

* [11859]: Remove the spec doc info about the MsgSetSendEnabled that's part of another PR.

* [11859]: Update the changelog.

* Revert "[11859]: Update the changelog."

This reverts commit 85052b8.

* [11859]: Rename the QuerySendEnabled message to QuerySendEnabledRequest to match the other messages in that proto.

* [11859]: Remove the authority field that is only needed for governance stuff (in the other PR).

* [11859]: Add a version to the deprecation message.

* [11859]: Update the comment on the now-deprecated SendEnabled params proto field to reference 0.46 instead of 0.47.

* Add some spacing to GetCmdQuerySendEnabled -> RunE.

* [11859]: Create banktypes.GenesisState.GetAllSendEnabled() to house the combination logic of the SendEnabled field and Params.SendEnabled. Have MigrateSendEnabled() use that. Remove some calls to MigrateSendEnabled and use GetAllSendEnabled in those cases.

* [11859]: Update Bank's ConsensusVersion to 4.

* [11859]: Add 'Since' comments to the new proto stuff.

* [11859]: Fix a unit test that broke because it assumed the bank module's version was 3.

* [11859]: Remove an empty line.

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* [11859]: Remove movement of SendEnabled from the `ExportGenesis` function too.

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* [11859]: Add a function for getting an entry so that users can differentiate between a missing entry and one that's using the default value.

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Fix a unit test that was failing to compile.

* Update the changelog.

* Fix the bank module's migration order since it's different for us than the main sdk.

* Remove some stuff that isn't actually needed (probably added by mistake with the initial merge).

Co-authored-by: Daniel Wedul <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
* Implement the Custom Message Fees.

* Add changelog entry for custom fee handler.

* Only add the fee events when in deliver or simulate mode (just like the antevents).

* Fix double call to msCache.Write and clean up when we should and shouldn't do that write.

* Switch it up again. The write should only happen if there's no FeeInvoke error AND we're in deliver mode. The events should be updated if there wasn't an error and we're either in deliver or simulate mode.

* Yet another switch-up on that stuff to better match the patterns used in the other parts. Should be cleaner now.

Co-authored-by: Daniel Wedul <[email protected]>
(cherry picked from commit fe89212)

Co-authored-by: Ari Rubinstein <[email protected]>
* chore: bump math package

* changelog
…osmos#12888) (cosmos#12890)

* fix(x/group): propagate events correctly to current context (cosmos#12888)

* fix(x/groups) propagate events correctly to current context

* update to use current context on logger

* adding changelog entry

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
(cherry picked from commit 014bfae)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Damian Nolan <[email protected]>
Co-authored-by: Amaury M <[email protected]>
…nction (#223)

* Add the IMsgServiceRouter interface and the SetMsgServiceRouter function.

* Don't return the context anymore from runTx since it is not used anywhere. This puts it back to closer to what the sdk has (same signature at least).

* Use the IMsgServiceRouter in a few more spots in place of a *MsgServiceRouter.

* Revert "Don't return the context anymore from runTx since it is not used anywhere. This puts it back to closer to what the sdk has (same signature at least)."

This reverts commit f550756.

* Add changelog entry.
* Create a FindAuthorization function to replace the GetCleanAuthorization function that they removed. It doesn't try to delete an expired grant though, so I thought I'd call it something a little different, and getGrant was already used.

* Have FindAuthorization return a reference to the expiration since it seems that changed to a reference in the grants too.

* Fix FindAuthorization to account for th epossibility that the expiration is nil.

* Change the name to GetAuthorization and return a nil expiration when nothing is returned.

* Add some unit tests for GetAuthorization.

* Add changelog entry.
* Add a sim state decocoder for the auth account number entries.

* Don't change account numbers during auth InitGenesis when the genesis state is missing one.

* Tweak auth InitGenesis to make sure that GetNextAccountNumber is called when there's only 1 account with the number 0.

* Update SanitizeGenesisAccounts to update accounts with duplicated account numbers so that all account numbers are unique.

* Add some unit tests on the AccountKeeper's InitGenesis function.

* Add some unit tests on the SanitizeGenesisAccounts changes.

* add a comment about using a *uint64 (instead of just a uint64).
* chore: bump tendermint to `0.34.21` and iavl to `0.19.1`

* update changelog
* docs(cli): improve --gas flag description

* Update client/flags/flags.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* fix sprintf

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit f430528)

Co-authored-by: Robert Zaremba <[email protected]>
…os#12981) (cosmos#12998)

* fix: proper error when parsing telemetry configuration (cosmos#12981)

When parsing `telemetry.global-labels` config the code assumes that the type will be an array.  I saw an issue where someone edited the configuration in the wrong way and got the following error:
![photo_2022-08-21_08-02-21](https://user-images.githubusercontent.com/22855163/185793842-c5759a54-1860-4dd1-bdb4-b94f4dab3c16.jpg)
Instead, I suggest here to print a proper error log to indicate what the issue is.

(cherry picked from commit c24c439)

* add changelog

Co-authored-by: liorbond <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
* Create release notes.

* Adding changes needed by rewards module to propagete event history to end and begin blockers, see provenance-io/provenance#626 for details.

* removing RELEASE_NOTES.md because this on 0.46.x track

Co-authored-by: Daniel Wedul <[email protected]>
* Grab the buf.gen.swagger.yaml file from main and update protoc-swagger-gen.sh with main's version too.

* Add changelog entry.

* make proto-swagger-gen

* Update the statik.go file with the updated swagger files.
Copy link
Contributor

coderabbitai bot commented Nov 21, 2023

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@SpicyLemon
Copy link
Collaborator Author

Sorry. Accidentally opened this against the wrong fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.