fix: abort watch correctly for protobuf client #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
reviewed
Sep 17, 2024
frezbo
approved these changes
Sep 17, 2024
There were two bugs: * `io.EOF` was ignored for no good reason * the aggregated/non-aggregated was not properly handled for errors This should fix COSI controller runtime not crashing on connection close via gRPC. Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
fix/proto-watch-abort
branch
from
5e072dd to
01bd2dc
Compare
Unix4ever
approved these changes
Sep 17, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two bugs:
io.EOFwas ignored for no good reasonThis should fix COSI controller runtime not crashing on connection close via gRPC.