Add metric name in limiter per-metric exceeded errors #6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Essam Eldaly <[email protected]>
Signed-off-by: Essam Eldaly <[email protected]>
Signed-off-by: Essam Eldaly <[email protected]>
yeya24
reviewed
Dec 12, 2024
CHANGELOG.md
Outdated
| @@ -46,11 +46,12 @@ | |||
| * [ENHANCEMENT] Add new option `-server.grpc_server-num-stream-workers` to configure the number of worker goroutines that should be used to process incoming streams. #6386 | |||
| * [ENHANCEMENT] Distributor: Return HTTP 5XX instead of HTTP 4XX when instance limits are hit. #6358 | |||
| * [ENHANCEMENT] Ingester: Make sure unregistered ingester joining the ring after WAL replay. #6277 | |||
| * [ENHANCEMENT] Distributor: Add a new `-distributor.num-push-workers` flag to use a goroutine worker pool when sending data from distributor to ingesters. #6406 | |||
| * [ENHANCEMENT] Added metric name in limiter per-metric exceeded errors | |||
There was a problem hiding this comment.
Can we include the PR number here?
pkg/ingester/limiter.go
Outdated
| if actualLimit := l.maxSeriesPerMetric(userID); series < actualLimit { | ||
| return nil | ||
| } | ||
|
|
||
| return errMaxSeriesPerMetricLimitExceeded | ||
| return errors.Wrap(errMaxSeriesPerMetricLimitExceeded, "{metric name: " + metric + "}") |
There was a problem hiding this comment.
Can we change errMaxSeriesPerMetricLimitExceeded to take metric name as a parameter and we use errors.Wrapf(errMaxSeriesPerMetricLimitExceeded, metric)?
There was a problem hiding this comment.
We already have the labels on the handleAppendFailure, no? we can just send those labels down to format the error?
There was a problem hiding this comment.
Ex:
cortex/pkg/ingester/ingester.go
Line 1161 in 6be0378
Signed-off-by: Essam Eldaly <[email protected]>
Signed-off-by: Essam Eldaly <[email protected]>
Signed-off-by: Essam Eldaly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds metric name in limiter per-metric exceeded errors
Which issue(s) this PR fixes:
Fixes #6416
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]