Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary level filter #6392

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 3, 2024

Signed-off-by: Ben Ye [email protected]

What this PR does:

Clean up the logging code a bit before we switch to use slog.

LevelFilter is not needed anymore as the common package already switch to use go-kit/log. See the TODO comment there.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the type/chore Something that needs to be done; not a bug or a feature label Dec 3, 2024
@SungJin1212
Copy link
Contributor

Thanks :D

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2024
@yeya24 yeya24 merged commit 8751c97 into cortexproject:master Dec 3, 2024
16 checks passed
@yeya24 yeya24 deleted the chore-cleanup-levelfilter branch December 3, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size/S type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants