Cache Matchers on ingesters #6382
Draft
+145
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should hold this PR for now and create the one in thanos first? @yeya24 WDYT? |
alanprot
force-pushed
the
cache-matcher
branch
2 times, most recently
from
a9b1ecd to
3a382d5
Compare
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
cache-matcher
branch
from
3a382d5 to
a08f18a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Ingesters can burn out when a query when receiving queries with a huge regex expression.
This PR is caching the matchers so we dont need to compile the regex over and over again.
We also need to do this for SG.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]