Add metrics to track ingesting native histograms #6370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Track-native-histogram-in-ingester
branch
2 times, most recently
from
021bc82 to
2e01fdb
Compare
3 tasks
SungJin1212
force-pushed
the
Track-native-histogram-in-ingester
branch
from
2e01fdb to
d39de75
Compare
yeya24
reviewed
Nov 25, 2024
pkg/ingester/ingester.go
Outdated
| } | ||
|
|
||
| // Distributor counts both samples, metadata and histograms, so for consistency ingester does the same. | ||
| i.ingestionRate.Add(int64(succeededSamplesCount + ingestedMetadata)) | ||
| i.ingestionRate.Add(int64(succeededSamplesCount + succeededHistogramCount + ingestedMetadata)) | ||
|
|
||
| switch req.Source { | ||
| case cortexpb.RULE: | ||
| db.ingestedRuleSamples.Add(int64(succeededSamplesCount)) |
pkg/ingester/ingester.go
Outdated
| @@ -1400,7 +1413,7 @@ func (i *Ingester) Push(ctx context.Context, req *cortexpb.WriteRequest) (*corte | |||
| if errors.As(firstPartialErr, &ve) { | |||
| code = ve.code | |||
| } | |||
| level.Debug(logutil.WithContext(ctx, i.logger)).Log("msg", "partial failures to push", "totalSamples", succeededSamplesCount+failedSamplesCount, "failedSamples", failedSamplesCount, "firstPartialErr", firstPartialErr) | |||
| level.Debug(logutil.WithContext(ctx, i.logger)).Log("msg", "partial failures to push", "totalSamples", succeededSamplesCount+succeededHistogramCount+failedSamplesCount+failedHistogramCount, "failedSamples", failedSamplesCount, "failedHistogram", failedHistogramCount, "firstPartialErr", firstPartialErr) | |||
There was a problem hiding this comment.
If we want to separate out samples and histograms then let's add a dedicated totalHistograms.
failedHistogram => failedHistograms
| // we must already have copied the labels if succeededHistogramCount has been incremented. | ||
| return copiedLabels | ||
| }) | ||
| } |
There was a problem hiding this comment.
Can we combine this part with the code above so that we only update series once?
shouldUpdateSeries := (succeededSamplesCount > oldSucceededSamplesCount) || (succeededHistogramCount > oldSucceededHistogramsCount)
if i.cfg.ActiveSeriesMetricsEnabled && shouldUpdateSeries {...}
There was a problem hiding this comment.
Can we introduce a variable instead? To avoid the line to be too long
SungJin1212
force-pushed
the
Track-native-histogram-in-ingester
branch
3 times, most recently
from
2defe54 to
2fb3ec3
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Track-native-histogram-in-ingester
branch
from
2fb3ec3 to
49a2cbc
Compare
|
@alanprot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two ingester metrics
cortex_ingester_ingested_native_histograms_totalandcortex_ingester_ingested_native_histograms_failures_totalto track ingesting native histogram.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]