Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote write v2 proto #6320

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SungJin1212
Copy link
Contributor

@SungJin1212 SungJin1212 commented Nov 7, 2024

Part of #6292.
This PR adds remote write v2 proto and PreallocTimeseries like v1.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

//
// For Go, see github.com/prometheus/prometheus/model/timestamp/timestamp.go
// for conversion from/to time.Time to Prometheus timestamp.
int64 timestamp = 15;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At v2, the naming of unix timestamp is converted from timestamp_ms to timestamp for all of (exemplar, sample, and histogram).
So, I re-defined Histogram instead of using the existing one.

@SungJin1212 SungJin1212 force-pushed the Add-remote-write-v2-proto branch from 6e0054a to ab3963d Compare November 8, 2024 07:44
@SungJin1212 SungJin1212 marked this pull request as draft November 11, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant