-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs:Add support rule evaluation via query frontend docs #6200
base: master
Are you sure you want to change the base?
docs:Add support rule evaluation via query frontend docs #6200
Conversation
@yeya24 |
d79a2cf
to
cfb6ed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
frontend_address: query-frontend.svc.cluster.local:9095 | ||
``` | ||
|
||
In addition, you can configure gRPC client (Ruler -> Query Frontend) config via args: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is unnecessary to list all configuration flags. This adds extra complexity for users who read this doc as I expect that most of the case default values should be good enough.
Is it possible to use a link to redirect to the frontend client configurations?
backoff_config: | ||
min_period: 100ms | ||
max_period: 10s | ||
max_retries: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
## Pros and Cons | ||
|
||
### Pros | ||
The rule evaluation performance is improved as we can use Query Frontend features like the vertical query sharding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of performance, I think it is complex and it is not always true to say evaluation performance is improved.
By evaluating rules through Query Frontend, there are more hops in this path. Ruler -> Query Frontend -> Query Scheduler -> Querier -> Ingester/Store Gateway.
Query Frontend/Query Scheduler has a query queue and Querier pulls queries from the queue to execute. If there are not enough queriers, add rule queries to this path could cause query starvation problem and rules cannot get evaluated. I think this is something to call out in this doc.
|
||
### Pros | ||
The rule evaluation performance is improved as we can use Query Frontend features like the vertical query sharding. | ||
The ruler can use fewer resources as it doesn't need to initialize the querier anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds vague to me. You mean in the code Ruler doesn't need to intialize the querier struct? I suggest rewording it to something like:
Ruler can use fewer resources as it doesn't need to run query engine to evaluate rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, what I mean is that. Let me fix it.
|
||
## How to enable | ||
|
||
By default, the Ruler queries to the Ingesters for evaluating rules (alerting rules or recording rules). If you have set `-ruler.frontend-address` then the Ruler query to the Query Frontend for evaluation rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Ruler queries the Ingesters.
the Ruler queries the Query Frontend.
Ruler queries both Ingesters and Store Gateway depending on the Rule time range.
cfb6ed4
to
438d722
Compare
428b05c
to
6849497
Compare
@yeya24 |
f4d0a80
to
298ef9e
Compare
298ef9e
to
dfd861f
Compare
Signed-off-by: SungJin1212 <[email protected]>
dfd861f
to
d4de9be
Compare
@yeya24 |
What this PR does:
Add docs on configuring Ruler to evaluate rules via Query Frontend and the pros and cons of this feature.
Which issue(s) this PR fixes:
Fixes #6198
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]