Partitioning Compactor #6084
Draft
Partitioning Compactor #6084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
yeya24
reviewed
Jul 11, 2024
pkg/compactor/meta_extenstions.go
Outdated
| "github.com/thanos-io/thanos/pkg/block/metadata" | ||
| ) | ||
|
|
||
| type CortexMetaExtensions struct { |
There was a problem hiding this comment.
Can we move this file to pkg/storage/tsdb? So that it can be shared by other components
yeya24
reviewed
Jul 11, 2024
pkg/compactor/testutils/block.go
Outdated
| "github.com/cortexproject/cortex/pkg/storage/tsdb" | ||
| ) | ||
|
|
||
| func GenerateBlock(ctx context.Context, logger log.Logger, cfg BlockGenConfig, storageCfg tsdb.BlocksStorageConfig) error { |
There was a problem hiding this comment.
Let's exclude this file first? At least, it seems not being used for now
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
harry671003
reviewed
Jul 23, 2024
|
|
||
| import "syscall" | ||
|
|
||
| func SysProcAttr() *syscall.SysProcAttr { |
There was a problem hiding this comment.
Is this intended? Why are the vendor files modified without any go.mod change?
harry671003
reviewed
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
TBD
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]