Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing slice sort for user scanner unit test #5700

Merged

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 7, 2023

What this PR does:

actual is appended via iterating a map so we need to sort to make the results deterministic in UT.

Captured the case in https://github.com/cortexproject/cortex/actions/runs/7122829006/job/19394470594?pr=5699

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@alanprot alanprot merged commit a85f3c1 into cortexproject:master Dec 7, 2023
14 checks passed
@yeya24 yeya24 deleted the fix-flaky-user-scanner-unit-tests branch December 7, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants