-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use caching bucket for compactor, except cleaner #5682
Merged
yeya24
merged 6 commits into
cortexproject:master
from
wenxu1024:caching-bucket-compactor
Dec 7, 2023
Merged
use caching bucket for compactor, except cleaner #5682
yeya24
merged 6 commits into
cortexproject:master
from
wenxu1024:caching-bucket-compactor
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Dec 5, 2023
yeya24
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add unit tests in compactor_test.go
to make sure it works as expected
wenxu1024
force-pushed
the
caching-bucket-compactor
branch
from
December 5, 2023 22:25
6a516da
to
e7f39a2
Compare
yeya24
reviewed
Dec 7, 2023
Signed-off-by: Wen Xu <[email protected]>
…r and tenant deletion marker for compactor Signed-off-by: Wen Xu <[email protected]>
…to the feature flag Signed-off-by: Wen Xu <[email protected]>
Signed-off-by: Wen Xu <[email protected]>
Signed-off-by: Wen Xu <[email protected]>
wenxu1024
force-pushed
the
caching-bucket-compactor
branch
from
December 7, 2023 02:52
e8885ed
to
3c58f66
Compare
Signed-off-by: Wen Xu <[email protected]>
yeya24
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Use Caching Bucket for compactor operations, except the cleaner which serves as the source of truth for tenant bucket index.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]