Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use caching bucket for compactor, except cleaner #5682

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

wenxu1024
Copy link
Contributor

@wenxu1024 wenxu1024 commented Nov 28, 2023

What this PR does:

Use Caching Bucket for compactor operations, except the cleaner which serves as the source of truth for tenant bucket index.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

pkg/compactor/compactor.go Outdated Show resolved Hide resolved
pkg/compactor/compactor.go Outdated Show resolved Hide resolved
pkg/compactor/compactor.go Outdated Show resolved Hide resolved
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add unit tests in compactor_test.go to make sure it works as expected

@wenxu1024 wenxu1024 force-pushed the caching-bucket-compactor branch from 6a516da to e7f39a2 Compare December 5, 2023 22:25
@pull-request-size pull-request-size bot added size/L and removed size/S labels Dec 5, 2023
pkg/compactor/compactor.go Outdated Show resolved Hide resolved
pkg/compactor/compactor_test.go Outdated Show resolved Hide resolved
@wenxu1024 wenxu1024 force-pushed the caching-bucket-compactor branch from e8885ed to 3c58f66 Compare December 7, 2023 02:52
Signed-off-by: Wen Xu <[email protected]>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This LGTM.

@yeya24 yeya24 enabled auto-merge (squash) December 7, 2023 17:19
@yeya24 yeya24 merged commit ab3ca0a into cortexproject:master Dec 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants