Alert history log support #5602
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Lodovice <[email protected]>
emanlodovice
force-pushed
the
alert-history-log
branch
from
a13ac1c to
b989eb5
Compare
|
IIUC, this requires some prs to upstream alertmanager first? |
|
yes, this PR needs this PR in upstream alertmanager prometheus/alertmanager#3461 so I am keeping it as draft so I can get some preliminary review |
emanlodovice
force-pushed
the
alert-history-log
branch
from
b989eb5 to
52d0fa1
Compare
Signed-off-by: Emmanuel Lodovice <[email protected]>
emanlodovice
force-pushed
the
alert-history-log
branch
from
52d0fa1 to
b00cc53
Compare
qinxx108
reviewed
Nov 29, 2023
pkg/alertmanager/alert_observer.go
Outdated
|
|
||
| func (o *LogAlertLifeCycleObserver) PipelineStart(alerts []*types.Alert, meta alertobserver.AlertEventMeta) { | ||
| logLvl := o.limiter.Level() | ||
| if logLvl < 2 { |
There was a problem hiding this comment.
nit: should we create a function as shouldLog? so that we can put all level control logic in there
qinxx108
reviewed
Nov 29, 2023
pkg/alertmanager/alert_observer.go
Outdated
| reason = "Unknown" | ||
| } | ||
| for _, a := range alerts { | ||
| o.logWithAlert(a, true, "msg", "Rejected", "reason", reason) |
There was a problem hiding this comment.
do we need reject per log? maybe log rejected alerts in the same line better for less log volume?
qinxx108
reviewed
Nov 29, 2023
pkg/alertmanager/alert_observer.go
Outdated
| return | ||
| } | ||
| for _, a := range alerts { | ||
| o.logWithAlert(a, true, "msg", "Added to aggregation group", "groupKey", groupKey) |
Signed-off-by: Emmanuel Lodovice <[email protected]>
qinxx108
reviewed
Jan 18, 2024
| "github.com/prometheus/alertmanager/api" | ||
| "github.com/prometheus/alertmanager/cluster" | ||
| "github.com/prometheus/alertmanager/cluster/clusterpb" | ||
| "github.com/prometheus/alertmanager/config" | ||
| "github.com/prometheus/alertmanager/dispatch" | ||
| "github.com/prometheus/alertmanager/featurecontrol" |
There was a problem hiding this comment.
nit: is this belong to this change?
There was a problem hiding this comment.
This is needed to support the latest changes in AM. This change prometheus/alertmanager#3045 adds a featurecontrol parameter to NewPipelineBuilder.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]