Retry chunk pool exhaustion error at querier #5562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er level Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
| return true | ||
| } | ||
|
|
||
| func yoloString(buf []byte) string { |
There was a problem hiding this comment.
I guess you meant to rename this func?
There was a problem hiding this comment.
That's the name :)
We have same function in other places.
|
I will close this pr and open a new one. Due to the new retry we added, some more refactoring is required. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Retry chunk pool exhaustion error at querier, but ignore it at query frontend retry middleware.
The idea is that when a request got chunk pool exhaustion error, retrying the whole query at query frontend is more expensive than retry at querier as querier only retries a single request so few blocks.
If the request still failed after 3 retries at querier, then we don't have to retry at query frontend again as the fleets might already overloaded.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]