Add retries for instant query #5560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
force-pushed
the
retry_instant_query
branch
2 times, most recently
from
ded52d2 to
54a899f
Compare
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
retry_instant_query
branch
from
54a899f to
e3f869b
Compare
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
|
We probably need to change code added in #5062. Now since we are going to add a general retry layer, we should remove the code of that code to let all requests go to round tripper. It will cause some performance issue but I think worth it. |
3 tasks
|
I'll close this in lieu of #5561. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds retries for instant queries.
There is also some refactoring done to avoid duplicating the code for
mockLimits.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]