Update to go 1.21 #5510
Closed
Update to go 1.21 #5510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated build-image/Dockerfile as instructed at https://cortexmetrics.io/docs/contributing/how-to-update-the-build-image/ Signed-off-by: Neo2308 <[email protected]>
Neo2308
force-pushed
the
feature/master/update-to-go-1.21
branch
from
b9a1423 to
96a8c55
Compare
|
Waiting for a maintainer to push the build image to quay (Steps 2-4 on https://cortexmetrics.io/docs/contributing/how-to-update-the-build-image/). Once that is done, I can make the rest of the changes in this PR. |
friedrichg
reviewed
Aug 14, 2023
Signed-off-by: Friedrich Gonzalez <[email protected]>
yeya24
reviewed
Aug 30, 2023
|
Hi @Neo2308, sorry for the late response. I have built the image based on this branch and pushed the image to quay. This is the image. Please let me know if you are still willing to continue this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updated build-image/Dockerfile as instructed at https://cortexmetrics.io/docs/contributing/how-to-update-the-build-image/
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]