Fix yaml empty node validation #5490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralicky
force-pushed
the
fix-issue-5488
branch
from
cf63a84 to
53e45ed
Compare
alanprot
reviewed
Aug 22, 2023
Comment on lines
+93
to
+94
| yaml: "flusher: { exit_after_flush: false }", | ||
| stderrExcluded: "empty YAML node", |
There was a problem hiding this comment.
Hum.. why this should be invalid?
There was a problem hiding this comment.
This is a test case that fails under the old validation logic, but should not fail with the updated code.
There was a problem hiding this comment.
There are some more details in the linked issue.
There was a problem hiding this comment.
oh ok..
that make sense i guess...
|
Can i sign the DCO? |
|
Sure, do you want me to update the changelog as well? or is that automated? |
kralicky
force-pushed
the
fix-issue-5488
branch
from
53e45ed to
78b0b56
Compare
…tead of checking the struct after unmarshaling Signed-off-by: Joe Kralicky <[email protected]>
kralicky
force-pushed
the
fix-issue-5488
branch
from
78b0b56 to
62b06f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR improves the yaml empty node validation for the cortex config by inspecting the yaml ast directly instead of checking the struct after unmarshaling.
Which issue(s) this PR fixes:
Fixes #5488
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]