remove retry on chunk pool exhaustion error for now

Signed-off-by: Ben Ye <[email protected]>
cortexproject · Sep 12, 2023 · 8e5d555 · 8e5d555
1 parent 9f21ea5
commit 8e5d555
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 31 deletions.
diff --git a/pkg/querier/blocks_store_queryable.go b/pkg/querier/blocks_store_queryable.go
@@ -1121,8 +1121,6 @@ func isRetryableError(err error) bool {
 	case codes.Canceled:
 		return strings.Contains(err.Error(), "grpc: the client connection is closing")
 	// TODO(yeya24): change Thanos to use ResourceExhausted for chunk pool error.
-	case codes.Unknown:
-		return strings.Contains(err.Error(), "allocate chunk bytes")
 	default:
 		return false
 	}

diff --git a/pkg/querier/blocks_store_queryable_test.go b/pkg/querier/blocks_store_queryable_test.go
@@ -667,35 +667,6 @@ func TestBlocksStoreQuerier_Select(t *testing.T) {
 				},
 			},
 		},
-		"multiple store-gateways has the block, but one of them fails to return due to chunk pool exhaustion": {
-			finderResult: bucketindex.Blocks{
-				{ID: block1},
-			},
-			storeSetResponses: []interface{}{
-				map[BlocksStoreClient][]ulid.ULID{
-					&storeGatewayClientMock{
-						remoteAddr:      "1.1.1.1",
-						mockedSeriesErr: status.Error(codes.Unknown, "load chunks: populate chunk: allocate chunk bytes: pool exhausted"),
-					}: {block1},
-				},
-				map[BlocksStoreClient][]ulid.ULID{
-					&storeGatewayClientMock{remoteAddr: "2.2.2.2", mockedSeriesResponses: []*storepb.SeriesResponse{
-						mockSeriesResponse(labels.Labels{metricNameLabel, series1Label}, minT, 2),
-						mockHintsResponse(block1),
-					}}: {block1},
-				},
-			},
-			limits:       &blocksStoreLimitsMock{},
-			queryLimiter: noOpQueryLimiter,
-			expectedSeries: []seriesResult{
-				{
-					lbls: labels.New(metricNameLabel, series1Label),
-					values: []valueResult{
-						{t: minT, v: 2},
-					},
-				},
-			},
-		},
 		"all store-gateways return PermissionDenied": {
 			finderResult: bucketindex.Blocks{
 				{ID: block1},