Skip to content

Commit

Permalink
Update cortex_ingester_inflight_push_requests metric description
Browse files Browse the repository at this point in the history
Signed-off-by: alanprot <[email protected]>
  • Loading branch information
alanprot committed Dec 18, 2024
1 parent 3ec967b commit 3b6fab0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* [CHANGE] Change all max async concurrency default values `50` to `3` #6268
* [CHANGE] Change default value of `-blocks-storage.bucket-store.index-cache.multilevel.max-async-concurrency` from `50` to `3` #6265
* [CHANGE] Enable Compactor and Alertmanager in target all. #6204
* [CHANGE] Update the `cortex_ingester_inflight_push_requests` metric to represent the maximum number of inflight requests recorded in the last minute. #6437
* [FEATURE] Ruler: Pagination support for List Rules API. #6299
* [FEATURE] Query Frontend/Querier: Add protobuf codec `-api.querier-default-codec` and the option to choose response compression type `-querier.response-compression`. #5527
* [FEATURE] Ruler: Experimental: Add `ruler.frontend-address` to allow query to query frontends instead of ingesters. #6151
Expand Down
2 changes: 1 addition & 1 deletion pkg/ingester/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func newIngesterMetrics(r prometheus.Registerer,

inflightRequests: promauto.With(r).NewGaugeFunc(prometheus.GaugeOpts{
Name: "cortex_ingester_inflight_push_requests",
Help: "Current number of inflight push requests in ingester.",
Help: "Max number of inflight push requests in ingester on the last minute.",
}, func() float64 {
if inflightPushRequests != nil {
return float64(inflightPushRequests.Load())
Expand Down
2 changes: 1 addition & 1 deletion pkg/ingester/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func TestIngesterMetrics(t *testing.T) {
require.NotNil(t, m)

err := testutil.GatherAndCompare(mainReg, bytes.NewBufferString(`
# HELP cortex_ingester_inflight_push_requests Current number of inflight push requests in ingester.
# HELP cortex_ingester_inflight_push_requests Max number of inflight push requests in ingester on the last minute.
# TYPE cortex_ingester_inflight_push_requests gauge
cortex_ingester_inflight_push_requests 14
# HELP cortex_ingester_max_inflight_query_requests Max number of inflight query requests in ingester.
Expand Down

0 comments on commit 3b6fab0

Please sign in to comment.